Enable Feature.DiffInformedQueries - #2970
Merged
cklin merged 4 commits intoJul 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cklin
force-pushed
the
cklin/diff-informed-feature-enable
branch
from
91304fa to
56692c1
Compare
July 16, 2025 18:10
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the Feature.DiffInformedQueries feature by default and restricts it to GHES versions 3.19 or higher. The primary goal is to make diff-informed queries available to more users while ensuring compatibility with supported GHES versions.
- Changed the default value for Feature.DiffInformedQueries from false to true
- Added GHES version checking to restrict the feature to version 3.19 or higher
- Added comprehensive test coverage for the new GHES version validation logic
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/feature-flags.ts | Updates default value for DiffInformedQueries feature from false to true |
| src/diff-informed-analysis-utils.ts | Adds GHES version checking logic to restrict feature to 3.19+ |
| src/diff-informed-analysis-utils.test.ts | Adds comprehensive test cases for diff-informed analysis functionality |
| lib/feature-flags.js | Compiled JavaScript version of the TypeScript feature flag changes |
| lib/diff-informed-analysis-utils.test.js | Compiled JavaScript version of the TypeScript test file |
| lib/diff-informed-analysis-utils.js | Compiled JavaScript version of the TypeScript utility changes |
Sorry, something went wrong.
cklin
force-pushed
the
cklin/diff-informed-feature-enable
branch
from
56692c1 to
4447fc3
Compare
July 16, 2025 18:18
mbg
previously approved these changes
Jul 17, 2025
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks for changing this and adding tests! Just one minor question / suggestion.
Sorry, something went wrong.
Comment thread
src/diff-informed-analysis-utils.ts
Outdated
cklin
force-pushed
the
cklin/diff-informed-feature-enable
branch
from
4447fc3 to
6a49a8c
Compare
July 17, 2025 13:17
mbg
approved these changes
Jul 17, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Feature.DiffInformedQueries to be enabled on GHES versions 3.19 or higher.
Merge / deployment checklist