Treat processing error for multiple runs with the same category as configuration error - #2987
Merged
mbg merged 1 commit intoJul 23, 2025
Merged
mbg merged 1 commit into
mbg merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…nfiguration error This will result in it being reported as a user error rather than a failure
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates error handling to treat "multiple runs with the same category" as a configuration error rather than a processing failure. This change ensures that such errors are reported as user errors instead of system failures.
- Adds a new expected configuration error message to the error classification logic
- Updates both TypeScript source and compiled JavaScript to maintain consistency
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/upload-lib.ts | Adds new error message to expectedConfigErrors array for proper classification |
| lib/upload-lib.js | Generated JavaScript equivalent of the TypeScript changes |
Sorry, something went wrong.
koesie10
approved these changes
Jul 23, 2025
koesie10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will result in it being reported as a user error rather than a failure
Merge / deployment checklist