Cleanup extract to toolcache feature flag - #3021
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the "extract to toolcache" feature flag that has been successfully rolled out for several months, simplifying the CodeQL bundle extraction code by eliminating the conditional behavior.
- Removes the ExtractToToolcache and ZstdBundleStreamingExtraction feature flags from the feature flags system
- Simplifies CodeQL bundle extraction logic by removing the conditional paths and always using the new extraction behavior
- Updates function signatures across the codebase to remove the now-unnecessary features parameter
Reviewed Changes
Copilot reviewed 16 out of 24 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/feature-flags.ts | Removes the ExtractToToolcache and ZstdBundleStreamingExtraction feature flag definitions |
| src/setup-codeql.ts | Removes feature flag parameter and simplifies downloadCodeQL function by removing conditional extraction logic |
| src/upload-lib.ts | Removes features parameter from initCodeQL call |
| src/init.ts | Removes features parameter from initCodeQL function signature |
| src/init-action.ts | Removes features parameter from initCodeQL call |
| src/codeql.ts | Removes features parameter from setupCodeQL function signature |
| src/setup-codeql.test.ts | Updates test calls to remove features parameter |
| src/codeql.test.ts | Removes feature-related test utilities and updates test calls |
| lib/*.js | Generated JavaScript files mirroring the TypeScript changes |
src/codeql.test.ts:170
- Extra blank line added on line 169. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:204
- Extra blank line added on line 203. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:287
- Extra blank line added on line 286. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:320
- Extra blank line added on line 319. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:357
- Extra blank line added on line 357. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:391
- Extra blank line added on line 391. This appears to be an unintentional formatting change that should be removed.
false,
src/codeql.test.ts:427
- Extra blank line added on line 427. This appears to be an unintentional formatting change that should be removed.
false,
Sorry, something went wrong.
mbg
left a comment
There was a problem hiding this comment.
All LGTM, thanks!
Minor point: Reviewing the commit that removes the extract-directly-to-toolcache FF would have benefitted from a link to #2631 in the commit message or PR description to point at the context for this to make it quicker to review.
Sorry, something went wrong.
|
Looks like the PR checks also need updating |
Sorry, something went wrong.
This has been rolled out for a couple of months without any issues, so remove the feature flag and clean up the old code paths.
Merge / deployment checklist