PR checks: support collections of workflows - #3030
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for collections of workflows in the PR checks system. It allows grouping related workflow checks (like Go-related checks) into collections that can be executed together.
- Adds collection functionality to the PR checks sync script
- Introduces workflow inputs for parameterizing check execution
- Creates a consolidated "go" collection containing all Go-related checks
Reviewed Changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pr-checks/sync.py | Main implementation adding collection support and workflow input handling |
| pr-checks/checks/go-*.yml | Go check specifications updated with collection membership and inputs |
| .github/workflows/__go.yml | New generated collection workflow for running all Go checks together |
| .github/workflows/__*.yml | Generated workflow files updated with workflow_call and workflow_dispatch inputs |
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
Nice! I like this. There is a little bit of awkwardness in the "go-version" input not being used in any of the steps, but it's not blocking.
Sorry, something went wrong.
|
I manually dispatched a run of __go.yml with a Go RC as input to check that all works as expected with the workflow_dispatch and workflow_call triggers: https://github.com/github/codeql-action/actions/runs/16963696649 |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great. Thanks for the extra cleanup!
Sorry, something went wrong.
This is a sort-of experimental idea that I had in the context of #3028 where we bump the Go version in the workflows to a release candidate for testing purposes, but such PRs don't have to be merged anymore because the existing constraint of >= 1.22 would include allow new version once it is fully released.
This PR updates the sync.py script to allow "collections" of PR checks that can be triggered manually, with specific inputs. So instead of creating a PR that bumps the Go version for testing purposes only, we could instead just dispatch the collection workflow with the desired Go version.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist