Add analysis-kinds input - #3061
Merged
mbg merged 7 commits intoAug 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…uality-queries` For backwards compatibility. We should remove this once `quality-queries` is no longer in use.
Replaces the synthetic value for `analysisKinds`
henrymercer
reviewed
Aug 28, 2025
Comment thread
init/action.yml
Comment on lines
+54
to
+55
| - `code-quality`: Analysis focused on code quality. This must be enabled in conjunction | ||
| with `code-scanning`. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Out of interest, where's this restriction coming from? We can address it in a follow up PR, but I think we want to be able to run code quality only analyses.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yes, this restriction will be lifted in a follow-up PR. It's just representative of the current state of the implementation as of this PR.
Sorry, something went wrong.
henrymercer
previously approved these changes
Aug 28, 2025
henrymercer
approved these changes
Aug 28, 2025
mbg
disabled auto-merge
August 28, 2025 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up from #3055 and adds an analysis-kinds input to the init action. This is a required input, but defaults to code-scanning so that there's no change to existing workflows. The input is parsed and the resulting analysis kinds are stored in the configuration.
The isCodeQualityEnabled function is updated to inspect that configuration, instead of the quality-queries input.
For backwards compatibility, we enable the code-quality analysis kind if there is an input to quality-queries.
Fundamentally, this PR shouldn't change the existing behaviour of the Action in any way.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist