FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix update-bundle workflow by aibaars · Pull Request #3073 · github/codeql-action · GitHub

/ codeql-action Public

Fix update-bundle workflow - #3073

Merged
aibaars merged 2 commits into
mainfrom
aibaars/update-bundle
Sep 2, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Fix update-bundle workflow#3073
aibaars merged 2 commits into
mainfrom
aibaars/update-bundle

Conversation

aibaars commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

aibaars requested a review from a team as a code owner September 2, 2025 15:29
Copilot AI review requested due to automatic review settings September 2, 2025 15:29
aibaars force-pushed the aibaars/update-bundle branch from 6f63204 to 5864756 Compare September 2, 2025 15:29
Copilot AI reviewed Sep 2, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR fixes the update-bundle workflow by adding a missing dependency installation step. The workflow is triggered when a CodeQL bundle prerelease is published and automates the process of updating the default bundle version.

  • Adds npm ci step to install dependencies before running build commands

henrymercer previously approved these changes Sep 2, 2025
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Could we also add a:

      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
          node-version: '20.x'
          cache: 'npm'

step? That'll cache the dependencies and should speed things up.

aibaars force-pushed the aibaars/update-bundle branch from 5864756 to d5dbc12 Compare September 2, 2025 17:26
aibaars enabled auto-merge September 2, 2025 17:39
henrymercer approved these changes Sep 2, 2025
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

aibaars merged commit 16df4fb into main Sep 2, 2025
278 checks passed
aibaars deleted the aibaars/update-bundle branch September 2, 2025 17:52
github-actions Bot mentioned this pull request Sep 5, 2025
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL