Accept git_source registry configurations for Go - #3079
Merged
mbg merged 2 commits intoSep 4, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for git_source registry configurations for the Go language in the CodeQL Action's start-proxy functionality. This allows Go projects to use Git-based sources in addition to the existing goproxy_server registry type.
Key Changes
- Modified the language-to-registry-type mapping to support multiple registry types per language
- Updated Go language to accept both goproxy_server and git_source registry types
- Added comprehensive test coverage for the new multi-registry functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/start-proxy.ts | Updated LANGUAGE_TO_REGISTRY_TYPE to support arrays of registry types and modified credential filtering logic to handle multiple types per language |
| src/start-proxy.test.ts | Added test cases to verify Go language accepts both goproxy_server and git_source registry types, and refactored existing tests to use shared test data |
| lib/start-proxy-action.js | Generated JavaScript file (no review needed per guidelines) |
Sorry, something went wrong.
aibaars
approved these changes
Sep 4, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows git_source registry configurations for Go.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist