Dump soon to be uploaded SARIF on request - #3097
Merged
redsun82 merged 2 commits intoSep 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This introduces a new internal environment variable flag (`CODEQL_ACTION_SARIF_DUMP_DIR`) that, when set to `true`, causes the SARIF file that will be uploaded to be dumped to the specified directory. The filename will be `upload.sarif` or `upload.quality.sarif` depending on the upload target.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new internal environment variable flag that enables dumping the processed SARIF file to a specified directory before upload for testing and debugging purposes.
- Adds CODEQL_ACTION_SARIF_DUMP_DIR environment variable to control SARIF dumping
- Implements dumpSarifFile function to write processed SARIF content to disk
- Integrates SARIF dumping into the upload workflow with appropriate file naming
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/environment.ts | Adds new environment variable constant for SARIF dump directory |
| src/upload-lib.ts | Implements SARIF dumping functionality and integrates it into upload process |
Sorry, something went wrong.
Comment thread
src/upload-lib.ts
Outdated
esbena
approved these changes
Sep 10, 2025
mbg
reviewed
Sep 10, 2025
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It seems that I can't approve anymore now that the PR is merged, but consider this my approval on this PR as well :)
Sorry, something went wrong.
This was referenced Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new internal environment variable flag (CODEQL_ACTION_SARIF_DUMP_DIR) that, when set to true, causes the SARIF file that will be uploaded to be dumped to the specified directory. The filename will be upload.sarif or upload.quality.sarif depending on the upload target.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist