Specify Accept header for toolcache.downloadTool - #3120
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the toolcache.downloadTool function was not properly downloading artifacts from GitHub releases due to a missing Accept header. The change adds the application/octet-stream header to ensure the actual binary artifact is downloaded instead of JSON metadata.
- Adds the required Accept: application/octet-stream header to toolcache.downloadTool calls
- Fixes the issue introduced in PR #3110 where downloads were returning metadata instead of actual artifacts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/start-proxy-action.ts | Adds Accept header configuration to downloadTool call for proxy binary download |
| lib/start-proxy-action.js | Generated JavaScript version of the TypeScript changes |
Sorry, something went wrong.
|
Successfully tested that this also works with the fallback in #3121: https://github.com/github/codeql-action/actions/runs/17805925098?pr=3121 |
Sorry, something went wrong.
henrymercer
left a comment
There was a problem hiding this comment.
Thanks for testing the fallback method!
Sorry, something went wrong.
Fixes a bug with #3110, where we missed setting this header for toolcache.downloadTool that's needed to get the actual artifact, rather than the JSON metadata.
Better solution than #3119, since browser_download_url is intended for use by browsers.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist