Provide Authorization header when downloading update-job-proxy - #3146
Merged
mbg merged 4 commits intoSep 24, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the authorization header logic for downloading tools from GitHub by extracting common code into a reusable function and applying consistent authorization patterns to both CLI bundle and update-job-proxy downloads.
- Extracts authorization header logic into getAuthorizationHeaderFor function in api-client.ts
- Updates the start-proxy action to provide authorization headers when downloading update-job-proxy
- Refactors existing CodeQL CLI download logic to use the new common function
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/api-client.ts | Adds new getAuthorizationHeaderFor function to centralize authorization logic |
| src/start-proxy-action.ts | Updates proxy binary download to use authorization headers consistently |
| src/setup-codeql.ts | Refactors to use the new centralized authorization function |
| lib/*.js | Generated JavaScript files reflecting the TypeScript changes |
Sorry, something went wrong.
esbena
previously approved these changes
Sep 24, 2025
esbena
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, with some minor doc/log thoughts.
Sorry, something went wrong.
esbena
previously approved these changes
Sep 24, 2025
esbena
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the start-proxy action to provide an Authorization header for the toolcache.downloadTool call under the same circumstances where we provide one for the toolcache.downloadTool call when downloading the CLI bundle.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist