Hotfix upload-sarif not uploading non-.sarif files - #3160
Merged
mbg merged 2 commits intoSep 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the upload-sarif action was not uploading non-.sarif files for CodeScanning analysis. The fix modifies the file filtering logic to allow CodeScanning analysis to upload files that don't match the default SARIF predicate.
- Updates the conditional logic in findAndUpload to handle non-SARIF files for CodeScanning
- Adds specific handling for CodeScanning analysis kind when the file doesn't match standard SARIF extensions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/upload-sarif-action.ts | Updates TypeScript source to fix file filtering logic for CodeScanning analysis |
| lib/upload-sarif-action.js | Contains the compiled JavaScript equivalent of the TypeScript changes |
Sorry, something went wrong.
henrymercer
previously approved these changes
Sep 26, 2025
Copy link
Copy Markdown
Contributor
|
Add a changelog note? |
Sorry, something went wrong.
henrymercer
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slimmed down #3157
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist