Make matrix available to start-proxy action - #3174
Merged
mbg merged 2 commits intoOct 3, 2025
Merged
mbg merged 2 commits into
mbg merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This change adds the matrix input parameter to the start-proxy action, making it consistent with other actions in the codebase. The matrix value is used by createStatusReportBase and will enable matrix information to be included in start-proxy telemetry.
Key Changes
- Added matrix input parameter to start-proxy/action.yml with default value from GitHub Actions matrix context
- Maintained consistency with existing action interfaces by making the parameter optional
Sorry, something went wrong.
henrymercer
approved these changes
Oct 3, 2025
esbena
approved these changes
Oct 3, 2025
Copy link
Copy Markdown
Member
Author
|
You coordinated those reviews very well @henrymercer and @esbena 😄 within a few seconds of each other! |
Sorry, something went wrong.
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors what we have for the other actions. Used by createStatusReportBase. I considered changing getRequiredInput("matrix") to getOptionalInput("matrix") there (and think that makes sense as a change), but thought it would be useful to have the matrix value in the start-proxy telemetry as well if it is available.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist