| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This PR refactors the analyze action to use the uploadSarif function instead of making separate calls to uploadFiles for Code Scanning and Code Quality analyses. The change consolidates SARIF upload logic that was previously duplicated between the analyze and upload-sarif actions.
Key changes:
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/analyze-action.ts | Refactors upload logic to use uploadSarif and updates result handling to work with grouped results by analysis kind |
| lib/analyze-action.js | Generated JavaScript code reflecting the TypeScript changes, including new helper functions for SARIF file grouping |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, with one optional code style comment.
Sorry, something went wrong.
There was a problem hiding this comment.
This looks good. Thanks for adding the feature flag. I think you can update the classification in the PR description to low risk now.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This replaces the two calls to uploadFiles in the analyze action with one call to uploadSarif. We introduced uploadSarif in #3167 for the upload-sarif action. Using uploadSarif here means that we no longer use different implementations of the same logic in analyze and upload-sarif.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist