| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This PR changes the init action to process the analysis-kinds input before sending the starting status report, allowing the analysis kinds information to be included in that report.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| src/init-action.ts | Extracts status report sending to a helper function and moves analysis kinds initialization before the starting status report |
| src/config-utils.ts | Updates interface to accept parsed analysis kinds instead of raw input string, removes inline parsing logic |
| src/config-utils.test.ts | Updates test helper to use parsed analysis kinds array instead of input string |
| src/analyses.ts | Adds new initAnalysisKinds function that consolidates analysis kinds parsing and deprecated input handling |
| src/analyses.test.ts | Adds comprehensive test coverage for the new initAnalysisKinds function |
| lib/init-action.js | Generated JavaScript reflecting the TypeScript changes |
Sorry, something went wrong.
There was a problem hiding this comment.
Your alternative suggestion of ignoring the exception and then re-running initAnalysisKinds at the normal time seems more robust, but given that incorrect analysis kinds should be pretty rare, this seems OK too.
Sorry, something went wrong.
…uring the first call
There was a problem hiding this comment.
Looks reasonable
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR changes the init action so that the analysis-kinds input is processed before the starting status report is sent. This allows us to include information about the enabled analysis kinds in that report.
One aspect of this that we may want to think about is that, if the analysis-kinds input is invalid, we now throw a ConfigurationError for that before the starting report is sent. This will still get caught and result in a user-error status report, but without a matching starting status report.
Alternatives:
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist