Always skip database upload if AnalysisKind.CodeScanning is not enabled - #3221
Merged
mbg merged 1 commit intoOct 21, 2025
Merged
Always skip database upload if AnalysisKind.CodeScanning is not enabled#3221mbg merged 1 commit into
mbg merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CodeQL Action to skip database uploads when Code Scanning is not enabled as an analysis kind. This addresses the issue where the API endpoint for database uploads doesn't accept uploads without Code Scanning enabled, preventing unnecessary warnings in the workflow logs.
Key changes:
- Added an early return check in uploadDatabases to skip upload when AnalysisKind.CodeScanning is not included in the enabled analysis kinds
- Added corresponding unit test coverage to verify the new skip behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/database-upload.ts | Added check to skip database upload when Code Scanning analysis kind is not enabled |
| src/database-upload.test.ts | Added test case to verify database upload is skipped without Code Scanning enabled |
| lib/analyze-action.js | Generated JavaScript code corresponding to TypeScript changes |
Sorry, something went wrong.
henrymercer
approved these changes
Oct 21, 2025
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Databases that are produced if analysis-kinds: code-quality is the only enabled analysis kind are initialised for a different set of queries than those that are initialised if analysis-kinds: code-scanning is enabled. This shouldn't really be a problem in itself, but the API endpoint for database uploads also doesn't currently accept uploads if Code Scanning is not enabled. That results in a warning in the CodeQL Action, rather than an outright failure, but both of these points combined mean it probably makes sense for us to skip attempting a database upload.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist