Bump timeout for analyze-action-env test - #3228
Merged
mbg merged 2 commits intoOct 23, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the test timeout for the analyze-action-env test from the default value to 20 seconds to address frequent timeouts occurring on Windows.
Key Changes:
- Added a 20-second timeout configuration to the "analyze action with RAM & threads from environment variables" test
Sorry, something went wrong.
henrymercer
previously approved these changes
Oct 23, 2025
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Worth bumping for src/analyze-action-input.test.ts too? That test is pretty similar on the face of it.
Sorry, something went wrong.
henrymercer
approved these changes
Oct 23, 2025
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test seems to frequently timeout on Windows, so this PR bumps the timeout a bit.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Tests only.
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
N/A.
How will you know if something goes wrong after this change is released?
CI.
Merge / deployment checklist