Remove add-snippets input - #3239
Merged
mbg merged 3 commits intoOct 29, 2025
Merged
mbg merged 3 commits into
mbg merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated add-snippets input from the analyze action, which has been deprecated since CodeQL Action 3.26.4 in August 2024. The removal cleans up the codebase by eliminating the associated input parameter, helper function, and all references throughout the action's implementation.
Key changes:
- Removed the add-snippets input definition from analyze/action.yml
- Deleted the getAddSnippetsFlag() utility function and its tests
- Removed the addSnippetsFlag parameter from runQueries() and databaseInterpretResults() functions and all their call sites
- Updated CHANGELOG.md to document this breaking change
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| analyze/action.yml | Removed the deprecated add-snippets input definition |
| src/util.ts | Removed the getAddSnippetsFlag() helper function |
| src/util.test.ts | Removed tests for the deleted getAddSnippetsFlag() function |
| src/codeql.ts | Removed addSnippetsFlag parameter from databaseInterpretResults() interface and implementation |
| src/analyze.ts | Removed addSnippetsFlag parameter from runQueries() function signature |
| src/analyze-action.ts | Removed the call to getAddSnippetsFlag() when invoking runQueries() |
| src/analyze.test.ts | Removed addSnippetsFlag variable and parameter from test |
| src/analyze-action-input.test.ts | Updated argument index in test assertion after parameter removal |
| src/analyze-action-env.test.ts | Updated argument index in test assertion after parameter removal |
| CHANGELOG.md | Added entry documenting the removal of the add-snippets input |
| lib/*.js | Generated JavaScript code reflecting the TypeScript changes |
Sorry, something went wrong.
esbena
previously approved these changes
Oct 27, 2025
henrymercer
reviewed
Oct 27, 2025
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A lot of folks won't see the changelog, so perhaps it makes sense to create a warning when the input is specified to inform users that it is ignored.
Sorry, something went wrong.
mbg
force-pushed
the
mbg/remove/add-snippets
branch
from
3b10402 to
4ae68af
Compare
October 29, 2025 09:29
esbena
reviewed
Oct 29, 2025
Comment thread
analyze/action.yml
Resolved
Co-authored-by: Esben Sparre Andreasen <esbena@github.com>
esbena
approved these changes
Oct 29, 2025
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the add-snippets input from the analyze action. This input has been deprecated since CodeQL Action 3.26.4 in August 2024 when this removal was announced.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist