Support skipping workflow validation - #3240
Merged
mbg merged 5 commits intoOct 28, 2025
Merged
mbg merged 5 commits into
mbg merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an environment variable to skip workflow validation for internal use cases where workflows are known to be valid. The main changes include:
- Refactored workflow validation check into a dedicated checkWorkflow function in init.ts
- Added SKIP_WORKFLOW_VALIDATION environment variable to control validation
- Added comprehensive test coverage for the new function
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/init.ts | Added checkWorkflow function wrapping validation logic with environment variable check |
| src/init-action.ts | Replaced inline workflow validation with call to new checkWorkflow function |
| src/environment.ts | Added SKIP_WORKFLOW_VALIDATION enum entry with documentation |
| src/init.test.ts | Added three test cases covering validation, error logging, and skip scenarios |
| lib/*.js | Generated JavaScript code from TypeScript sources (auto-generated) |
Sorry, something went wrong.
henrymercer
reviewed
Oct 27, 2025
henrymercer
reviewed
Oct 27, 2025
Comment thread
src/init.ts
Resolved
mbg
force-pushed
the
mbg/allow-skip-workflow-validation
branch
from
0fd49a1 to
52cec41
Compare
October 27, 2025 17:02
henrymercer
approved these changes
Oct 27, 2025
This was referenced Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For internal use, we have CodeQL workflows that we know are valid and don't require validation on every run. This PR changes workflow validation so that it is always skipped for dynamic workflows. It also adds an environment variable which allows us to skip workflow validation.
This PR also slightly refactors the check into a function in workflow.ts and adds test coverage.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist