When diff-informed analysis is performed, PR diff-ranges are currently computed by the analyze action. This PR moves computation and persistence of PR diff-ranges to the init action instead. The motivation for moving the PR diff-range computation to the init action is to make it available for overlay analysis and include all files within the PR diff-range in the overlay-changes.json file generated for overlay analysis during the init action.
The commits have been cherry-picked from #3192 and modified.
Risk assessment
For internal use only. Please select the risk level of this change:
Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
Which use cases does this change impact?
Advanced setup - Impacts users who have custom workflows.
Default setup - Impacts users who use default setup.
Test repository - This change will be tested on a test repository before merging.
Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.
How will you know if something goes wrong after this change is released?
Telemetry - I rely on existing telemetry or have made changes to the telemetry.
Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
Merge / deployment checklist
Confirm this change is backwards compatible with existing workflows.
Consider adding a changelog entry for this change.
Confirm the readme and docs have been updated if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When diff-informed analysis is performed, PR diff-ranges are currently computed by the analyze action. This PR moves computation and persistence of PR diff-ranges to the init action instead. The motivation for moving the PR diff-range computation to the init action is to make it available for overlay analysis and include all files within the PR diff-range in the overlay-changes.json file generated for overlay analysis during the init action.
The commits have been cherry-picked from #3192 and modified.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist