Move conversion of PR diff-range paths to absolute paths by kaspersv · Pull Request #3248 · github/codeql-action · GitHub

Diff-informed analysis expects paths in the diff-range extension pack to be absolute paths. The conversion to absolute paths currently happens within getDiffRanges in diff-informed-analysis-utils.ts‎. This PR moves the conversion to writeDiffRangeDataExtensionPack in analyze.ts instead to allow getDiffRanges to be used from the init action in a future PR. As a result the diff-range paths written to pr-diff-range.json will be relative instead of absolute after this PR. This also requires a change to filterAlertsByDiffRange in upload-lib to filter based on relative paths instead of absolute paths.

The actual change occurs in commit 4. Commits 1 and 3 adds unit tests for affected functions and commit 2 exposes a function for testing.

Diff-informed analysis is guarded by the diff_informed_queries feature flag. The diff_informed_queries flag is already fully rolled out.

Risk assessment

For internal use only. Please select the risk level of this change:

Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Advanced setup - Impacts users who have custom workflows.
Default setup - Impacts users who use default setup.
Code Scanning - Impacts Code Scanning (i.e. analysis-kinds: code-scanning).
Code Quality - Impacts Code Quality (i.e. analysis-kinds: code-quality).
Third-party analyses - Impacts third-party analyses (i.e. upload-sarif).
GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

Test repository - This change will be tested on a test repository before merging.
Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

Telemetry - I rely on existing telemetry or have made changes to the telemetry.
- Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Consider adding a changelog entry for this change.
Confirm the readme and docs have been updated if necessary.

Pull Request Overview

This PR moves the conversion of PR diff-range paths to absolute paths from getDiffRanges in diff-informed-analysis-utils.ts to writeDiffRangeDataExtensionPack in analyze.ts. This refactoring enables getDiffRanges to be used from the init action in future changes, as it will now return relative paths instead of absolute paths. The conversion to absolute paths now happens when writing the extension pack, which is where the absolute paths are actually required.

Key Changes

getDiffRanges now returns relative file paths instead of absolute paths
diffRangeExtensionPackContents (new function) performs the path conversion when generating the extension pack
filterAlertsByDiffRange now compares relative paths instead of absolute paths

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/diff-informed-analysis-utils.ts	Removes absolute path conversion from getDiffRanges, now returns relative paths
src/diff-informed-analysis-utils.test.ts	Updates test expectations to match relative paths returned by getDiffRanges
src/analyze.ts	Adds diffRangeExtensionPackContents function that converts relative paths to absolute when creating extension pack
src/analyze.test.ts	Adds unit test for diffRangeExtensionPackContents function
src/upload-lib.ts	Updates filterAlertsByDiffRange to compare relative paths, exports function for testing
src/upload-lib.test.ts	Adds unit test for filterAlertsByDiffRange function
src/testdata/pr-diff-range.yml	New test fixture for extension pack content
src/testdata/valid-sarif-diff-filtered.sarif	New test fixture for filtered SARIF output

…emantics

…nge-absolute-path-conversion * origin/main: (32 commits) Add changelog note Update default bundle to codeql-bundle-v2.24.3 Bump tar from 7.5.7 to 7.5.10 Rebuild Rebuild Bump actions/upload-artifact from 6 to 7 in /.github/workflows Bump actions/download-artifact from 7 to 8 in /.github/workflows Bump the npm-minor group with 2 updates Fix some tests that should be serial Update method naming and JSDoc Rename to `EnabledOverlayConfig` Address review comments Use `Result`s for enablement return types Add disabled by env var disablement reason Rename to `usesDefaultQueriesOnly` Update `NonDefaultQueries` documentation Refactor `getOverlayDatabaseMode` and add new disablement reason Address review comments Add JSDoc Sort `OverlayDisabledReason` enum ...

…rsion

LGTM once we solve the merge conflict.

…rsion * main: (112 commits) Rebuild Update changelog and version after v4.33.0 Add changelog entry for #3570 Bump minor version Update changelog for v4.32.7 Only emit one message with accumulated property names Remove `cache-dependency-path` options as well Remove `package-lock.json` that's no longer needed Add step (in root directory) to install dependencies Add explicit cache dependency paths in `pr-checks.yml` Fix linter errors in `sync-back.test.ts` Fix linter errors in `sync-back.ts` Rename `sync_back` to `sync-back` Fix linter errors in `sync.ts` Add eslint configuration for `pr-checks` Add minimal `Step` type Add `workspaces` to root `package.json` Avoid bundling `package.json` Move `ava` config out of `package.json` Emit warning for unrecognised repo properties with our common prefix ... # Conflicts: # lib/init-action-post.js

github-actions Bot added the size/L May be hard to review label Oct 28, 2025

kaspersv force-pushed the kaspersv/move-diff-range-absolute-path-conversion branch from c7c3abd to 83a0d11 Compare October 28, 2025 12:39

kaspersv marked this pull request as ready for review October 28, 2025 14:04

kaspersv requested a review from a team as a code owner October 28, 2025 14:04

kaspersv requested review from Copilot and mbg October 28, 2025 14:04

Copilot AI reviewed Oct 28, 2025

View reviewed changes

kaspersv force-pushed the kaspersv/move-diff-range-absolute-path-conversion branch from 83a0d11 to a855e60 Compare November 10, 2025 14:56

kaspersv added 4 commits November 12, 2025 08:10

upload-lib: Unit test filterAlertsByDiffRange

035c117

Move diff-range extension pack generation into testable function

d18f3ac

Add unit test for diffRangeExtensionPackContents

df4e199

Move conversion of PR diff-range paths to absolute paths

4eb2475

kaspersv force-pushed the kaspersv/move-diff-range-absolute-path-conversion branch from a855e60 to 4eb2475 Compare November 12, 2025 07:12

henrymercer marked this pull request as draft January 15, 2026 19:45

sam-robson added 2 commits March 5, 2026 11:38

chore: merge main into kaspersv/move-diff-range-absolute-path-conversion

1443f58

refactor: pass checkoutPath as param and fix docs for relative path s…

b2de493

…emantics

sam-robson force-pushed the kaspersv/move-diff-range-absolute-path-conversion branch from 540115d to b2de493 Compare March 5, 2026 18:09

sam-robson added 3 commits March 6, 2026 09:10

refactor: pass checkoutPath as param to writeDiffRangeDataExtensionPack

cdafc35

Merge branch 'main' into kaspersv/move-diff-range-absolute-path-conve…

9082319

…rsion

sam-robson marked this pull request as ready for review March 9, 2026 11:53

henrymercer previously approved these changes Mar 11, 2026

View reviewed changes

sam-robson dismissed henrymercer’s stale review via 5e54629 March 18, 2026 10:48

henrymercer approved these changes Mar 18, 2026

View reviewed changes

sam-robson added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 08d1198 Mar 18, 2026
232 of 233 checks passed

sam-robson deleted the kaspersv/move-diff-range-absolute-path-conversion branch March 18, 2026 12:02

github-actions Bot mentioned this pull request Mar 20, 2026

Merge main into releases/v4 #3588

Merged

8 tasks

github-actions Bot mentioned this pull request Mar 20, 2026

Merge releases/v4 into releases/v3 #3590

Merged

8 tasks

Move conversion of PR diff-range paths to absolute paths by kaspersv · Pull Request #3248 · github/codeql-action · GitHub

Uh oh!

Move conversion of PR diff-range paths to absolute paths - #3248

Move conversion of PR diff-range paths to absolute paths#3248
sam-robson merged 10 commits into
mainfrom
kaspersv/move-diff-range-absolute-path-conversion

kaspersv commented Oct 28, 2025 •
edited
Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

henrymercer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Move conversion of PR diff-range paths to absolute paths by kaspersv · Pull Request #3248 · github/codeql-action · GitHub

Uh oh!

Move conversion of PR diff-range paths to absolute paths - #3248

Move conversion of PR diff-range paths to absolute paths#3248sam-robson merged 10 commits intomaingithub/codeql-action:mainfrom kaspersv/move-diff-range-absolute-path-conversiongithub/codeql-action:kaspersv/move-diff-range-absolute-path-conversionCopy head branch name to clipboard

Conversation

kaspersv commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Risk assessment

Which use cases does this change impact?

How did/will you validate this change?

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

How will you know if something goes wrong after this change is released?

Merge / deployment checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

henrymercer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Move conversion of PR diff-range paths to absolute paths#3248
sam-robson merged 10 commits into
mainfrom
kaspersv/move-diff-range-absolute-path-conversion

kaspersv commented Oct 28, 2025 •
edited
Loading