Use Node fs APIs instead of del - #3250
Merged
henrymercer merged 3 commits intoOct 28, 2025
Merged
henrymercer merged 3 commits into
henrymercer merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the del package dependency and replaces all its usages with Node's native fs.promises.rm API. This simplifies the codebase by eliminating an external dependency in favor of built-in functionality.
Key changes:
- Removed del package from dependencies in package.json
- Replaced all del.deleteAsync() calls with fs.promises.rm() across TypeScript source files
- Updated the compiled JavaScript files in lib/ directory to reflect these changes
Reviewed Changes
Copilot reviewed 11 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| package.json | Removed del dependency from dependencies list |
| src/util.ts | Replaced del.deleteAsync() with fs.promises.rm() in withTmpDir, bundleDb, and cleanUpGlob functions |
| src/debug-artifacts.ts | Replaced del.deleteAsync() with fs.promises.rm() in createPartialDatabaseBundle function |
| src/codeql.test.ts | Replaced del.deleteAsync() with fs.promises.rm() in test cleanup code |
| src/analyze.ts | Replaced del.deleteAsync() with fs.promises.rm() in runFinalize function |
| lib/*.js | Auto-generated JavaScript reflecting the TypeScript changes |
Sorry, something went wrong.
Comment thread
src/util.ts
Resolved
esbena
reviewed
Oct 28, 2025
esbena
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM with a very minor semantic concern.
Sorry, something went wrong.
Comment thread
src/util.ts
Resolved
esbena
previously approved these changes
Oct 28, 2025
esbena
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, but conflicts
Sorry, something went wrong.
esbena
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist