Make isEnablementError case-insensitive - #3258
Merged
mbg merged 1 commit intoOct 30, 2025
Merged
mbg merged 1 commit into
mbg merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the error message pattern matching in isEnablementError case-insensitive by adding the i flag to the regular expressions. This ensures that enablement errors are properly detected regardless of the casing used in error messages from the API.
Key Changes:
- Added case-insensitive flag (i) to three regex patterns in isEnablementError function
- Updated unit tests to verify case-insensitive matching with lowercase, uppercase, and original case transformations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/api-client.ts | Added i flag to regex patterns for case-insensitive enablement error detection |
| src/api-client.test.ts | Refactored tests to verify case-insensitive matching using multiple case transformations |
| lib/upload-sarif-action.js | Generated JavaScript with case-insensitive regex patterns |
| lib/upload-lib.js | Generated JavaScript with case-insensitive regex patterns |
| lib/setup-codeql-action.js | Generated JavaScript with case-insensitive regex patterns |
| lib/init-action.js | Generated JavaScript with case-insensitive regex patterns |
| lib/init-action-post.js | Generated JavaScript with case-insensitive regex patterns |
| lib/analyze-action.js | Generated JavaScript with case-insensitive regex patterns |
Sorry, something went wrong.
henrymercer
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3251 which makes the checks in isEnablementError case-insensitive.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Merge / deployment checklist