FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Create immutable action version on tag push by mbg · Pull Request #3264 · github/codeql-action · GitHub

  1. github
  2. codeql-action

Repository navigation

Create immutable action version on tag push - #3264

Merged
mbg merged 1 commit into
mainfrom
mbg/ci/publish-on-tag
Oct 31, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Create immutable action version on tag push#3264
mbg merged 1 commit into
mainfrom
mbg/ci/publish-on-tag

Conversation

mbg commented Oct 31, 2025

Copy link
Copy Markdown
Member

This PR changes the workflow that creates the immutable releases to trigger on tags getting pushed (only specific CodeQL Action version tags, not major version tags or CLI bundle tags), rather than releases being published.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Release CI.

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

If this results in a problem during the next release, we could manually run the workflow later for the relevant tag.

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

We will see during the next release.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

mbg requested a review from henrymercer October 31, 2025 16:28
mbg requested a review from a team as a code owner October 31, 2025 16:28
Copilot AI review requested due to automatic review settings October 31, 2025 16:28
github-actions Bot added the size/XS Should be very easy to review label Oct 31, 2025
Copilot AI reviewed Oct 31, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR modernizes the immutable action versioning workflow by changing its trigger from release publication events to tag push events. The change simplifies the workflow by eliminating the need for runtime checks to distinguish CodeQL Action releases from CLI bundle releases, as the tag pattern filter now handles this distinction at the workflow trigger level.

Key Changes

  • Changed workflow trigger from release.published to push.tags with version tag pattern filtering
  • Removed the conditional release name validation step that checked if releases were for the CodeQL Action
  • Simplified step names and removed conditional execution guards

Comment thread .github/workflows/publish-immutable-action.yml
push:
tags:
# Match version tags, but not the major version tags.
- 'v[0-9]+.**'

Copilot AI Oct 31, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The tag pattern 'v[0-9]+.' is incorrect glob syntax. The double asterisk '' is not a valid glob pattern for matching version numbers. This should be 'v[0-9]+.*' (single asterisk) to match tags like 'v3.29.9', or 'v[0-9]+.[0-9]+.[0-9]+' to explicitly match semantic version tags.

Suggested change
- 'v[0-9]+.**'
- 'v[0-9]+.*'

Copilot uses AI. Check for mistakes.

mbg Oct 31, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet

mbg enabled auto-merge October 31, 2025 16:45
mbg merged commit 338146c into main Oct 31, 2025
mbg deleted the mbg/ci/publish-on-tag branch October 31, 2025 16:48
This was referenced Nov 13, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL