Use generic types for durations in status report - #3278
Merged
henrymercer merged 1 commit intoNov 6, 2025
Merged
henrymercer merged 1 commit into
henrymercer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This means we don't need to update this interface for every new language.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the QueriesStatusReport interface to use TypeScript mapped types instead of manually listing each language-specific field. The refactoring reduces code duplication by generating field names dynamically from the KnownLanguage enum.
Key changes:
- Replaced ~90 lines of repetitive field definitions with concise mapped type definitions
- Introduced two helper types (RunQueriesDurationStatusReport and InterpretResultsDurationStatusReport) that generate language-specific field names
- The QueriesStatusReport interface now extends these mapped types
Sorry, something went wrong.
esbena
approved these changes
Nov 5, 2025
esbena
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
❤️
Sorry, something went wrong.
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means we don't need to update this interface for every new language.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Dev/test only
How did/will you validate this change?
The code compiles
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
n/a, dev only change
Merge / deployment checklist