FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix `update-supported-enterprise-server-versions.yml` workflow by mbg · Pull Request #3284 · github/codeql-action · GitHub

  1. github
  2. codeql-action

Repository navigation

Fix update-supported-enterprise-server-versions.yml workflow - #3284

Merged
mbg merged 4 commits into
mainfrom
mbg/ci/fix-enterprise-workflow
Nov 12, 2025
ConversationCommits (4)ChecksFiles changed
Merged

Fix update-supported-enterprise-server-versions.yml workflow#3284
mbg merged 4 commits into
mainfrom
mbg/ci/fix-enterprise-workflow

Conversation

mbg commented Nov 12, 2025

Copy link
Copy Markdown
Member

This has been failing for a while. The first commit should fix the issue that caused it to fail, while the others are slight improvements.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

CI only.

How did/will you validate this change?

CI.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

CI.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Copilot AI review requested due to automatic review settings November 12, 2025 15:10
mbg requested a review from a team as a code owner November 12, 2025 15:10
github-actions Bot added the size/XS Should be very easy to review label Nov 12, 2025
Copilot AI reviewed Nov 12, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR fixes a failing workflow that updates supported GitHub Enterprise Server versions. The main fix adds the missing npm ci step before npm run build, while additional improvements include enabling workflow testing via pull requests, optimizing repository checkout with sparse-checkout, and refactoring the commit/PR creation logic into separate steps.

Key Changes

  • Added npm ci before npm run build to ensure dependencies are installed
  • Split commit preparation and PR creation into separate steps with conditional logic to prevent PR creation during pull_request workflow runs
  • Added pull_request trigger to enable testing workflow changes in PRs

Comment thread .github/workflows/update-supported-enterprise-server-versions.yml
repository: github/enterprise-releases
token: ${{ secrets.ENTERPRISE_RELEASE_TOKEN }}
path: ${{ github.workspace }}/enterprise-releases/
sparse-checkout: releases.json

Copilot AI Nov 12, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The sparse-checkout parameter should be an array, not a string. According to the actions/checkout documentation, sparse-checkout expects a list of patterns, one per line.

Should be:

sparse-checkout: |
  releases.json
Suggested change
sparse-checkout: releases.json
sparse-checkout: |
releases.json

Copilot uses AI. Check for mistakes.
henrymercer approved these changes Nov 12, 2025
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, thanks! We should also look at reporting failures so we notice if a scheduled workflow starts failing in the future.

mbg enabled auto-merge November 12, 2025 15:23
mbg merged commit ba454b8 into main Nov 12, 2025
248 checks passed
mbg deleted the mbg/ci/fix-enterprise-workflow branch November 12, 2025 15:35
This was referenced Nov 13, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL