Add support for adding setup-dotnet steps to sync.sh - #3289
Merged
henrymercer merged 4 commits intoNov 13, 2025
Merged
henrymercer merged 4 commits into
henrymercer merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for installing specific versions of .NET in PR check workflows, mirroring existing functionality for Go, Java, and Python. This enables pinning .NET versions for tests that may not work with the default installation.
- Extends sync.py to generate setup-dotnet steps when installDotNet: true is specified in test configurations
- Adds .NET installation to the local-bundle test which validates C# language support
- Uses .NET 9.x as the default version with the ability to override via workflow inputs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pr-checks/sync.py | Adds logic to generate .NET installation steps following the same pattern as Go, Java, and Python installations, including workflow input configuration |
| pr-checks/checks/local-bundle.yml | Enables .NET installation for the local bundle test which includes C# among its tested languages |
| .github/workflows/__local-bundle.yml | Auto-generated workflow file reflecting the changes from sync.py (adds .NET installation step and corresponding workflow inputs) |
Sorry, something went wrong.
mbg
force-pushed
the
mbg/ci/setup-dotnet
branch
from
c53de4e to
1dec2ec
Compare
November 13, 2025 19:22
mbg
force-pushed
the
mbg/ci/setup-dotnet
branch
from
1dec2ec to
38a3a72
Compare
November 13, 2025 19:48
henrymercer
approved these changes
Nov 13, 2025
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good if checks pass
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors work we have done for other languages / ecosystems to allow us to pin specific versions of .NET for tests that might not work with whatever is available by default.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
CI only.
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
CI.
Merge / deployment checklist