Merge main into v1 - #338
Merged
robertbrignull merged 64 commits intoDec 7, 2020
Merged
robertbrignull merged 64 commits into
robertbrignull merged 64 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, most tests were using https://github.com and only the first was using https://github.example.com. As it happens, https://github.com works for all of them.
Introduce parameter object for API params that travel together
Fix deprecated method Buffer.new
Remove the line to disable the "github/no-then" rule.
Update code so "github/no-then" passes
Validate the codeql-action workspace for common errors
Add a check to ensure expected CodeQL release files exist.
So that we can remove support for the beta configuration of `on: push`-only we should communicate a date after which this will not work.
Add an explicit deprecation date
Backport v1 into main
Handle the case where branches may be strings, wildcards
Merge v1 into main to fix conflicts
Copy link
Copy Markdown
Contributor
|
The first four PRs were also included in #328, and the remaining 6 (+2 mergeback PRs) are from this week. |
Sorry, something went wrong.
robertbrignull
approved these changes
Dec 7, 2020
robertbrignull
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Although there are 6 new PRs, there's barely anything new. The only substantial new piece of work from this week is the fix for the bug from last week.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 494945f into v1
Conductor for this PR is @robertbrignull
Contains the following pull requests: