Fix feature flag lookup when uploading DB - #3385
Merged
henrymercer merged 1 commit intoJan 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mbg
approved these changes
Jan 5, 2026
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the database upload feature where the Feature.UploadOverlayDbToApi feature flag lookup was missing the required codeql parameter. The bug was introduced in PR #3375 and would have caused a runtime error when attempting to upload overlay databases, as the feature flag requires CodeQL to check for tools feature support.
Key Changes
- Added the codeql parameter to the features.getValue() call for the UploadOverlayDbToApi feature flag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/database-upload.ts | Fixed feature flag lookup by passing the codeql parameter to getValue() |
| lib/analyze-action.js | Auto-generated JavaScript reflecting the TypeScript fix (not reviewed per guidelines) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature flag depends on CodeQL, so we must pass the CodeQL object to the lookup.
This bug was introduced in #3375 which hasn't been released yet, but it is affecting folks who use main.
I'll look at improving the feature flag lookup to avoid these kinds of mistakes in the future, but I'd like to get the fix out first.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
I'll use a test repository to check whether the fix worked.
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist