FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Disable TypeScript `noUnusedLocals` and `noUnusedParameters` options, already covered by eslint by mbg · Pull Request #3464 · github/codeql-action · GitHub

Disable TypeScript noUnusedLocals and noUnusedParameters options, already covered by eslint - #3464

Merged
mbg merged 1 commit into
mainfrom
mbg/disable-ts-unused-checks
Feb 6, 2026
Merged

Disable TypeScript noUnusedLocals and noUnusedParameters options, already covered by eslint#3464
mbg merged 1 commit into
mainfrom
mbg/disable-ts-unused-checks

Conversation

mbg commented Feb 6, 2026

Copy link
Copy Markdown
Member

Probably a controversial change, but:

  • We already use eslint, which has the same rules configured.
  • eslint allows the equivalent errors to be suppressed with comments. TypeScript allows unused parameter errors to be suppressed with a leading _ in the name, but there is no way to suppress unused locals.
  • While working on changes, it is annoying to get errors for this when testing partially complete code. Meanwhile eslint can be run on demand when it makes sense.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

mbg self-assigned this Feb 6, 2026
mbg requested a review from a team as a code owner February 6, 2026 00:22
Copilot AI review requested due to automatic review settings February 6, 2026 00:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot wasn't able to review any files in this pull request.

github-actions Bot added the size/XS Should be very easy to review label Feb 6, 2026
mbg changed the title Disable noUnusedLocals and noUnusedParameters Disable TypeScript noUnusedLocals and noUnusedParameters options, already covered by eslint Feb 6, 2026
mbg merged commit 9b3a0d2 into main Feb 6, 2026
251 checks passed
mbg deleted the mbg/disable-ts-unused-checks branch February 6, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL