| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This pull request adds a new ForceNightly feature flag that allows forcing the use of the nightly CodeQL CLI bundle in dynamic workflows (Default Setup, CCR, etc.). The feature flag is restricted to dynamic workflow events or test mode, preventing it from affecting advanced workflows. The PR includes comprehensive unit tests and an end-to-end PR check to validate the functionality.
Changes:
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file| File | Description |
|---|---|
| src/feature-flags.ts | Adds the ForceNightly feature flag definition with environment variable and default value |
| src/setup-codeql.ts | Implements logic to force nightly CLI when feature flag is enabled in dynamic workflows; adds JSDoc documentation and exports for testing |
| src/setup-codeql.test.ts | Adds comprehensive unit tests for nightly CLI selection via both explicit input and feature flag |
| pr-checks/checks/bundle-from-nightly.yml | Defines PR check template to validate ForceNightly feature works as expected |
| .github/workflows/__bundle-from-nightly.yml | Auto-generated workflow file from the PR check template |
| lib/*.js | Auto-generated JavaScript transpilation of TypeScript source changes (not reviewed per guidelines) |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM with some superficial logging observability/logging concerns.
Sorry, something went wrong.
Also set default `GITHUB_EVENT_NAME` in `setupActionsVars`
There was a problem hiding this comment.
The recent changes LGTM.
Sorry, something went wrong.
There was a problem hiding this comment.
I had a quick look over the last two commits.
Sorry, something went wrong.
|
@henrymercer I have made those changes and ran a test in a test repository. See the references in the PR timeline. |
Sorry, something went wrong.
There was a problem hiding this comment.
Latest (trivial) changes LGTM, and the sample run looks as advertised.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Adds a Feature which, when enabled, and the workflow was triggered by a dynamic event forces getCodeQLSource to pick the latest, nightly release.
Some drive-by improvements and observations:
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist