Prevent accidental analysis of the get-pip.py script. - #349
Merged
chrisgavin merged 1 commit intoDec 22, 2020
Merged
chrisgavin merged 1 commit into
chrisgavin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
cbraynor
approved these changes
Dec 22, 2020
2 tasks
Copy link
Copy Markdown
Contributor
Author
|
I've verified that this does fix the extraction of get-pip.py. The Action previously output these lines which are gone when running it with this branch: [2020-12-22 14:31:21] [build] [INFO] [2] Extracted file /home/runner/work/py2004/py2004/get-pip.py in 774ms [2020-12-22 14:31:21] [build] [INFO] [2] Extracted file /home/runner/work/py2004/py2004/get-pip.py in 774ms (Also a bunch of other imports of get-pip.py are no longer extracted too! 🎉) |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like in some cases this script gets analyzed. We can either remove it after running it, or just not save it at all.
Merge / deployment checklist