FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support find .sarif files recursively by picklebento · Pull Request #352 · github/codeql-action · GitHub

/ codeql-action Public

Support find .sarif files recursively - #352

Merged
robertbrignull merged 1 commit into
github:mainfrom
picklebento:main
Jan 4, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Support find .sarif files recursively#352
robertbrignull merged 1 commit into
github:mainfrom
picklebento:main

Conversation

picklebento commented Dec 23, 2020

Copy link
Copy Markdown

This addresses #220 by recursively calling fs.readdirSync()

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

robertbrignull approved these changes Jan 4, 2021
View reviewed changes

robertbrignull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for implementing this. The implementation is nice and simple and looks good to me.

The only thing I was worried about was if we'd get into loops with symbolic links, but looking at the documentation it looks like it'll be fine, and I even gave it a try locally and it was fine.

I think we could add a unit test of this but rather than delaying this PR it'll probably be easiest to merge now and I'll add a quick test.

robertbrignull merged commit 230cb9b into github:main Jan 4, 2021
robertbrignull mentioned this pull request Jan 4, 2021
Merged
2 tasks
ghost mentioned this pull request Jan 5, 2021
Closed
github-actions Bot mentioned this pull request Jan 11, 2021
Merged

jwgmeligmeyling commented Nov 3, 2022

Copy link
Copy Markdown

The workings of this feature is not documented in the action.yml nor readme, despite the checkmark for it.

Some examples would be helpful. For example, this recursive implementation does only work on folder names and not file names.

aeisenberg commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Some examples would be helpful. For example, this recursive implementation does only work on folder names and not file names.

Can you be more specific? You can specify a directory (which gets searched recursively for sarif files or a single file. Is there a feature you are looking for, but is not implemented here? Or are you just seeking clarity on the behaviour?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

robertbrignull robertbrignull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL