FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add minimumVersion values for language overlay flags by sam-robson · Pull Request #3550 · github/codeql-action · GitHub

/ codeql-action Public

feat: add minimumVersion values for language overlay flags - #3550

Merged
henrymercer merged 4 commits into
mainfrom
sam-robson/overlay-per-lang-min-bundle-version
Mar 11, 2026
ConversationCommits (4)ChecksFiles changed
Merged

feat: add minimumVersion values for language overlay flags#3550
henrymercer merged 4 commits into
mainfrom
sam-robson/overlay-per-lang-min-bundle-version

Conversation

sam-robson commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Add per-language minimumVersion values to the overlay analysis feature flags, so that each language's overlay feature is only enabled when the CLI version supports it.

Also remove feature flags for languages not yet GA or in staff-ship (actions, cpp, rust, swift)

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Copilot AI review requested due to automatic review settings March 5, 2026 17:11
sam-robson requested a review from a team as a code owner March 5, 2026 17:11
henrymercer reviewed Mar 5, 2026
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice! I checked the version numbers and they all look good. Consider adding a unit test that when a language isn't in OVERLAY_ANALYSIS_CODE_SCANNING_FEATURES overlay isn't enabled (see the existing tests in src/config-utils.test.ts). Otherwise this looks good to merge.

Copilot AI reviewed Mar 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions Bot added the size/M Should be of average difficulty to review label Mar 5, 2026
sam-robson force-pushed the sam-robson/overlay-per-lang-min-bundle-version branch 3 times, most recently from 4991213 to be82d93 Compare March 6, 2026 09:15
sam-robson requested a review from henrymercer March 6, 2026 15:03
mbg previously approved these changes Mar 6, 2026
View reviewed changes
henrymercer previously approved these changes Mar 9, 2026
View reviewed changes
Comment thread src/config-utils.test.ts
Comment on lines +2014 to +2020
// Verify that a language without a per-language overlay feature flag cannot have
// overlay analysis enabled, even when the base overlay feature flag is on.
// Using cpp here as it doesn't currently have overlay support — update this if
// cpp gains overlay support.
test.serial(
checkOverlayEnablementMacro,
"No overlay analysis for language without per-language overlay feature flag",

henrymercer Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could potentially write another test that checks that this stays up to date, specifically checking that C++ doesn't get added to OVERLAY_ANALYSIS_FEATURES. I'm OK with merging as is though.

Comment thread src/config-utils.ts Outdated
sam-robson dismissed stale reviews from henrymercer and mbg via 08925cd March 9, 2026 12:04
sam-robson enabled auto-merge March 9, 2026 13:11
sam-robson requested review from henrymercer and mbg March 9, 2026 13:11
mbg reviewed Mar 9, 2026
View reviewed changes

mbg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

08925cd just seems to include the updated comment and no test (despite the commit message) - I assume this isn't intentional?

sam-robson force-pushed the sam-robson/overlay-per-lang-min-bundle-version branch from 08925cd to 18af9a6 Compare March 9, 2026 16:45
sam-robson force-pushed the sam-robson/overlay-per-lang-min-bundle-version branch from 18af9a6 to 867f2b0 Compare March 9, 2026 16:46

sam-robson commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

08925cd just seems to include the updated comment and no test (despite the commit message) - I assume this isn't intentional?

Oops, a failed amended commit - I only intended to update the comment

sam-robson requested a review from mbg March 9, 2026 20:47
sam-robson added this pull request to the merge queue Mar 10, 2026
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
henrymercer added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 2e7e91f Mar 11, 2026
253 of 255 checks passed
henrymercer deleted the sam-robson/overlay-per-lang-min-bundle-version branch March 11, 2026 10:51
This was referenced Mar 16, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
henrymercer henrymercer approved these changes
mbg Awaiting requested review from mbg

Assignees

No one assigned

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL