Linting: Require unused function parameters to start with _ - #3561
Merged
mbg merged 1 commit intoMar 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s ESLint configuration to enforce that all unused function parameters must be explicitly marked as unused by starting with _, helping identify unnecessary computed/propagated values (e.g., when cleaning up legacy GHES code paths).
Changes:
- Configure @typescript-eslint/no-unused-vars to check all function parameters (args: "all").
- Keep the existing underscore-based opt-out via argsIgnorePattern: "^_".
Sorry, something went wrong.
mbg
approved these changes
Mar 9, 2026
Comment thread
eslint.config.mjs
| "@typescript-eslint/no-unused-vars": [ | ||
| "error", | ||
| { | ||
| "args": "all", |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Do you think that this is needed as of #3497 since it seemed to be working as expected before that?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I think that's likely, though I haven't checked.
Sorry, something went wrong.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Mar 9, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default setting for this lint rule doesn't check function parameters, but in our codebase we are often cleaning up code paths for older versions of GHES, therefore it's desirable to check whether something is being passed that we could possibly avoid computing in the first place.