FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Introduce external repository token by robertbrignull · Pull Request #357 · github/codeql-action · GitHub

/ codeql-action Public

Introduce external repository token - #357

Merged
robertbrignull merged 3 commits into
mainfrom
robertbrignull/external-token-option
Jan 14, 2021
ConversationCommits (3)ChecksFiles changed
Merged

Introduce external repository token#357
robertbrignull merged 3 commits into
mainfrom
robertbrignull/external-token-option

Conversation

robertbrignull commented Jan 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Potential alternative to #273 to demonstrate an idea.

Introduces GitHubApiExternalRepoDetails and GitHubApiCombinedDetails (names very open to changing) to get us type safety on the different types of api token.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Closes #273.

This was referenced Jan 4, 2021
Closed
Merged
chrisgavin approved these changes Jan 11, 2021
View reviewed changes

chrisgavin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This does seem like a fairly neat option to maintain the encapsulation. I'm happy with this method instead of #273.

robertbrignull force-pushed the robertbrignull/external-token-option branch from 44bb170 to 97a70e6 Compare January 12, 2021 12:09

robertbrignull commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

I forgot to include a couple of bits of #273 like the changes to the readme and to init/action.yml. I think I've got it all now and this should work but I'm going to give it a manual test before merging. @chrisgavin, could you have another quick look and see if you spot anything else I've missed?

robertbrignull commented Jan 14, 2021

Copy link
Copy Markdown
Contributor Author

I've tested this out locally with a private repository that could only be downloaded by passing the external repository token. It all seems good.

robertbrignull merged commit f86e200 into main Jan 14, 2021
robertbrignull deleted the robertbrignull/external-token-option branch January 14, 2021 17:41
github-actions Bot mentioned this pull request Jan 18, 2021
Merged
robertbrignull mentioned this pull request Jan 19, 2021
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
chrisgavin chrisgavin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

chrisgavin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL