Add eslint for pr-checks - #3572
Merged
mbg merged 11 commits intoMar 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mbg
force-pushed
the
mbg/pr-checks/eslint
branch
2 times, most recently
from
d25105c to
1621f40
Compare
March 12, 2026 18:16
mbg
force-pushed
the
mbg/pr-checks/eslint
branch
from
1621f40 to
994858d
Compare
March 12, 2026 19:13
mbg
force-pushed
the
mbg/pr-checks/eslint
branch
2 times, most recently
from
7a26f16 to
4b1f21e
Compare
March 12, 2026 19:52
mbg
marked this pull request as ready for review
March 12, 2026 19:52
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ESLint coverage for the pr-checks TypeScript code and updates CI and scripts so pr-checks code is linted and tested consistently alongside the main repo.
Changes:
- Extend the root ESLint flat config to include pr-checks/**/*.ts using pr-checks/tsconfig.json.
- Refactor pr-checks TypeScript to satisfy linting/type-checking (step typing and string template cleanups).
- Update CI workflows and scripts (caching, installs, and sync-back filename) and introduce npm workspaces wiring.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file| File | Description |
|---|---|
| pr-checks/sync.ts | Adds a minimal Step type and refactors string construction to be lint-friendly. |
| pr-checks/sync-back.ts | Formatting/import tweaks to satisfy lint rules. |
| pr-checks/sync-back.test.ts | Updates test text/import path and changes test registration style to satisfy linting. |
| eslint.config.mjs | Enables linting for pr-checks with the correct TS project and adjusts rules. |
| .github/workflows/pr-checks.yml | Adjusts caching and install steps; runs pr-checks tests without a local npm ci step. |
| .github/workflows/rebuild.yml | Updates script filename from sync_back.ts to sync-back.ts. |
| package.json | Adds npm workspaces configuration to include pr-checks. |
| package-lock.json | Updates lockfile to reflect workspaces and newly installed workspace deps. |
pr-checks/sync-back.test.ts:43
- Using async () => { await it(...) } changes the usual node:test pattern (register tests synchronously) and can subtly affect execution/ordering because it() is being treated as an awaitable. Once no-floating-promises is adjusted (e.g. via the ESLint safe-call allowlist), prefer keeping describe synchronous and calling it(...) without await (or using the conventional registration pattern) throughout this file.
Sorry, something went wrong.
mbg
force-pushed
the
mbg/pr-checks/eslint
branch
from
4b1f21e to
fc8d303
Compare
March 12, 2026 22:39
redsun82
previously approved these changes
Mar 13, 2026
Since `pr-checks` is now a workspace of the main `package.json`
redsun82
approved these changes
Mar 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Mar 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Mar 13, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Based on #3573, which should be merged first.)
Adds an eslint configuration for the pr-checks folder (largely based on the root configuration), updates the .ts files in pr-checks to resolve some linter errors.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist