Correct typo in setting of PR upload base ref - #361
Merged
rneatherway merged 3 commits intoJan 14, 2021
Merged
rneatherway merged 3 commits into
rneatherway merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
robertbrignull
approved these changes
Jan 13, 2021
Copy link
Copy Markdown
Contributor
Author
|
Great integration test! I see that my typo was just missing the curly brackets. |
Sorry, something went wrong.
robertbrignull
approved these changes
Jan 14, 2021
robertbrignull
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I see that my typo was just missing the curly brackets.
I suppose in hindsight I should have spotted that too. I wasn't sure what kind of refs we were dealing with or accepting, but this PR does make sense now. Thankfully by doing it wrong first we now know it sending the right kind of ref now.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist