Add tests for getCredentials with multiple goproxy_servers and maven_… - #3799
Merged
mario-campos merged 4 commits intoApr 7, 2026
Merged
Add tests for getCredentials with multiple goproxy_servers and maven_…#3799mario-campos merged 4 commits into
mario-campos merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit test coverage to ensure start-proxy’s getCredentials correctly returns multiple registry configurations of the same type for a given language.
Changes:
- Added a test verifying KnownLanguage.go returns all configured goproxy_server entries (and still includes git_source for Go).
- Added a test verifying KnownLanguage.java returns all configured maven_repository entries (and filters out non-Java registry types).
Sorry, something went wrong.
mario-campos
force-pushed
the
mario-campos/test-multiple-registries
branch
from
30f8fba to
a9a28d0
Compare
April 2, 2026 16:34
mbg
reviewed
Apr 7, 2026
mbg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Couple of minor points, otherwise this LGTM.
Sorry, something went wrong.
Co-authored-by: Michael B. Gale <mbg@github.com>
Co-authored-by: Michael B. Gale <mbg@github.com>
mario-campos
force-pushed
the
mario-campos/test-multiple-registries
branch
from
b422f8e to
35a3898
Compare
April 7, 2026 14:01
mbg
approved these changes
Apr 7, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) are parsed and reported appropriately. While one additional test would be sufficient to test this multi-registry use-case, I thought two tests across two languages offered a bit more safety.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist