Log some simple stats about the upload - #38
Merged
robertbrignull merged 2 commits intoMay 18, 2020
Merged
robertbrignull merged 2 commits into
robertbrignull merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
4 tasks
marcogario
approved these changes
May 15, 2020
marcogario
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Here are some demos: ##[debug]Raw upload size: 130372 bytes ##[debug]Base64 zipped upload size: 15640 bytes ##[debug]Number of results in upload: 25 ##[debug]Raw upload size: 319626 bytes ##[debug]Base64 zipped upload size: 19856 bytes ##[debug]Number of results in upload: 752 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log a few simple stats about the upload we're making, as requested by @marcogario. The logging is done at debug level so most users won't see it, but it could be useful for us.
This makes the assumption that the sarif file is valid and will fail if it isn't, but I intend to introduce validation of the sarif files imminently in another PR.
Merge / deployment checklist