Fix OIDC credential property names - #3807
Merged
mbg merged 2 commits intoApr 10, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the JSON property names used for OIDC credential configurations in the start-proxy action, switching from underscore-separated keys to hyphen-separated keys to match the expected schema.
Changes:
- Update OIDC config types and validators (Azure/AWS/JFrog) to use hyphenated JSON keys.
- Update getAuthConfig and credential pretty-printing to read/write the new keys.
- Update unit tests to use the new key names (and regenerate lib/ output).
| File | Description |
|---|---|
| src/start-proxy/types.ts | Switches OIDC config typing/validation and pretty-printing to hyphenated JSON property names. |
| src/start-proxy/types.test.ts | Updates fixtures/expectations for OIDC credential string formatting with new keys. |
| src/start-proxy.ts | Updates getAuthConfig normalization/output for OIDC configs to use hyphenated keys. |
| src/start-proxy.test.ts | Updates OIDC test fixtures to use the new hyphenated keys. |
| lib/start-proxy-action.js | Generated build output reflecting the TypeScript changes. |
Copilot's findings
- Files reviewed: 4/5 changed files
- Comments generated: 3
Sorry, something went wrong.
Comment thread
src/start-proxy.ts
Comment thread
src/start-proxy/types.ts
Comment thread
src/start-proxy.test.ts
henrymercer
previously approved these changes
Apr 9, 2026
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Changelog note?
Sorry, something went wrong.
henrymercer
approved these changes
Apr 10, 2026
mbg
enabled auto-merge
April 10, 2026 09:10
sam-robson
pushed a commit
that referenced
this pull request
Apr 10, 2026
Fix OIDC credential property names
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in #3563. The JSON property names use - instead of _.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist