Python setup: Fix URL for Python 2.7 pip install - #381
Merged
adityasharad merged 2 commits intoFeb 1, 2021
Merged
adityasharad merged 2 commits into
adityasharad merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This URL changed upstream. Fix it by using the same upstream URL as the LGTM Python image. We can revisit separately whether to drop the Python 2 pip installation entirely.
Daverlo
approved these changes
Jan 29, 2021
Daverlo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
aeisenberg
approved these changes
Jan 29, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks fine to me.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This URL changed upstream. Fix it by using the same upstream URL as the LGTM Python image.
We can revisit separately whether to drop the Python 2 pip installation entirely.
cc @robertbrignull @Daverlo @aeisenberg
Merge / deployment checklist