Allow overriding path of temporary files. - #385
Merged
chrisgavin merged 4 commits intoFeb 15, 2021
Merged
chrisgavin merged 4 commits into
chrisgavin merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
chrisgavin
force-pushed
the
allow-override-temp
branch
from
4ff8b58 to
ed751ec
Compare
February 1, 2021 15:34
chrisgavin
marked this pull request as ready for review
February 1, 2021 15:38
aeisenberg
reviewed
Feb 13, 2021
Comment thread
src/actions-util.ts
Outdated
chrisgavin
force-pushed
the
allow-override-temp
branch
from
cda6cac to
7b72f1c
Compare
February 15, 2021 11:45
aeisenberg
approved these changes
Feb 15, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I believe the Rubocop CI check failure is caused by a bug in the latest release of Bundler (ruby/rubygems#4380). We might want to pin to a specific version in future, but for now I think we can just wait for an update. |
Sorry, something went wrong.
This was referenced Feb 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so you can override the temporary directory used by the Action by setting the CODEQL_ACTION_TEMP environment variable.
I went with an environment variable instead of an input, both because I think it's advantageous to be able to override this for all jobs on self-hosted runners and because it allows you to set it once for the entire workflow rather than for each step.
This option is a useful escape hatch for Windows hosted runners, which have a very fast, but also very small temporary disk. This is used by default, but if the project is too big to build on this disk it's potentially useful to be able to use the larger, slower disk instead.
Merge / deployment checklist