Convert update-supported-enterprise-server-versions script to TypeScript - #3916
Merged
mbg merged 16 commits intoJun 18, 2026
Merged
Convert update-supported-enterprise-server-versions script to TypeScript#3916mbg merged 16 commits into
mbg merged 16 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing Python automation under .github/workflows/update-supported-enterprise-server-versions/ with a TypeScript implementation under pr-checks/, and updates the scheduled workflow to run the new script via Node/tsx.
Changes:
- Add pr-checks/update-ghes-versions.ts (plus unit tests) to compute and update src/api-compatibility.json from an enterprise-releases checkout.
- Update .github/workflows/update-supported-enterprise-server-versions.yml to run the TypeScript script (Node 24 + npm ci) instead of Python/pipenv.
- Remove the old Python script and Pipenv files; add semver dependency to the pr-checks workspace (and update the root lockfile).
| File | Description |
|---|---|
| pr-checks/update-ghes-versions.ts | New TS implementation for determining supported GHES version range and updating src/api-compatibility.json. |
| pr-checks/update-ghes-versions.test.ts | Unit tests for the new TS script logic (parsing, date helpers, range selection). |
| pr-checks/package.json | Adds semver dependency for the new script. |
| pr-checks/config.ts | Exposes API_COMPATIBILITY_FILE path for use by the new script. |
| .github/workflows/update-supported-enterprise-server-versions.yml | Switches workflow execution from Python to Node/TypeScript and rebuilds after updating compatibility data. |
| .github/workflows/update-supported-enterprise-server-versions/update.py | Removes the previous Python implementation. |
| .github/workflows/update-supported-enterprise-server-versions/Pipfile | Removes Pipenv configuration no longer needed. |
| .github/workflows/update-supported-enterprise-server-versions/Pipfile.lock | Removes Pipenv lockfile no longer needed. |
| package-lock.json | Updates workspace dependency graph (including semver resolution). |
| lib/upload-lib.js | Generated artifact update due to dependency graph changes (not reviewed). |
| lib/entry-points.js | Generated artifact update due to dependency graph changes (not reviewed). |
Copilot's findings
- Files reviewed: 7/11 changed files
- Comments generated: 5
Sorry, something went wrong.
Comment thread
pr-checks/update-ghes-versions.ts
Comment thread
pr-checks/update-ghes-versions.ts
Outdated
Comment thread
pr-checks/update-ghes-versions.ts
Comment thread
pr-checks/package.json
redsun82
previously approved these changes
Jun 18, 2026
Copy link
Copy Markdown
Member
Author
|
@redsun82 Thanks for reviewing! There were some minor merge conflicts, which I have resolved now. Can you re-approve? :) |
Sorry, something went wrong.
mbg
enabled auto-merge
June 18, 2026 13:44
oscarsj
approved these changes
Jun 18, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the Python code in .github/workflows/update-supported-enterprise-server-versions to TypeScript in pr-checks.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist