Clean up codeql.resolveLanguages - #3954
Merged
henrymercer merged 2 commits intoJun 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Only the betterjson option is now used, so remove the old version.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the CodeQL CLI language-resolution API by removing the legacy betterResolveLanguages method and standardizing on a single resolveLanguages implementation that uses the --format=betterjson output.
Changes:
- Replace all call sites of betterResolveLanguages() with resolveLanguages().
- Update stubs/mocks in unit tests to align with the new resolveLanguages method name and output expectations.
- Simplify the CodeQL interface by removing the old JSON-format resolveLanguages variant and keeping only the betterjson-based behavior.
| File | Description |
|---|---|
| src/workflow.ts | Switch language alias resolution to call codeql.resolveLanguages(). |
| src/workflow.test.ts | Update stubbing to match the renamed resolveLanguages() API. |
| src/trap-caching.ts | Use resolveLanguages() to query extractor metadata for TRAP caching support. |
| src/trap-caching.test.ts | Update stubbed CodeQL implementation to provide resolveLanguages(). |
| src/config-utils.ts | Use resolveLanguages({ filterToLanguagesWithQueries }) for supported language detection. |
| src/config-utils.test.ts | Update stub implementations and expectations for resolveLanguages() output. |
| src/codeql.ts | Remove the old JSON resolveLanguages method and rename betterjson variant to resolveLanguages. |
| lib/entry-points.js | Generated output updated to reflect the TypeScript changes (not reviewed). |
Copilot's findings
- Files reviewed: 7/8 changed files
- Comments generated: 1
Sorry, something went wrong.
Comment thread
src/codeql.ts
navntoft
approved these changes
Jun 5, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the betterjson option is now used, so remove the old version.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist