Fix broken log grouping due to nested log group - #3955
Merged
henrymercer merged 1 commit intoJun 5, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes noisy/mis-grouped GitHub Actions logs by removing a nested log group (“Computing PR diff ranges”) that was being emitted while already inside the “Load language configuration” group (nested log groups aren’t supported). The diff-range computation is now indicated via a plain informational log message instead of a group.
Changes:
- Remove the withGroupAsync("Computing PR diff ranges", ...) wrapper from prepareDiffInformedAnalysis.
- Add a logger.info("Computing PR diff ranges...") message at the start of computeAndPersistDiffRanges.
| File | Description |
|---|---|
| src/diff-informed-analysis-utils.ts | Removes the nested log group and replaces it with a simple info log to avoid broken grouping output. |
| lib/entry-points.js | Generated build output reflecting the TypeScript change (not reviewed). |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
Sorry, something went wrong.
navntoft
approved these changes
Jun 5, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Computing PR diff ranges" log group was nested within the "Load language configuration" log group. Since Actions doesn't support nested log groups this was creating some noise in the logs where the last part of "Load language configuration" spilled out into the top-level logs.
This PR simply removes the "Computing PR diff ranges" log group in favour of a log message instead.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist