Increase the default amount of RAM reserved for the OS - #396
Merged
adityasharad merged 2 commits intoFeb 17, 2021
Merged
adityasharad merged 2 commits into
adityasharad merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Mitigation for OOM errors (137/SIGKILL) seen by users when we overcommit the available memory. For Unix, reserve 1GB. For Windows, reserve 1.5GB, as the OS needs more memory and estimates inaccurately.
adityasharad
requested review from
aeisenberg,
chrisgavin and
robertbrignull
February 16, 2021 23:25
adityasharad
marked this pull request as ready for review
February 16, 2021 23:26
chrisgavin
approved these changes
Feb 16, 2021
chrisgavin
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. I suppose there is some risk that repositories that could previously be analyzed with 6.75GB of RAM might not be able to be analyzed with 6GB, but I agree that improving stability is the most important thing.
Sorry, something went wrong.
This was referenced Feb 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigation for OOM errors (137/SIGKILL) seen by users when we overcommit the available memory.
For Unix, reserve 1GB.
For Windows, reserve 1.5GB, as the OS needs more memory and estimates inaccurately.
Potential impact: There's a risk of this slightly increasing run times, but I think 1-1.5GB is rarely enough to dramatically change performance, and we've discussed that the improved stability is worth the tradeoff. I'm doing some simple performance testing, but to evaluate the full impact we may need to ship this and monitor overall runtimes.
Merge / deployment checklist