Set externalRepoAuth - #397
Merged
robertbrignull merged 1 commit intoFeb 17, 2021
Merged
robertbrignull merged 1 commit into
robertbrignull merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I missed that. Thanks for catching. I'll take this over. |
Sorry, something went wrong.
aeisenberg
force-pushed
the
robertbrignull/runner_auth
branch
from
f04b21a to
a265353
Compare
February 17, 2021 16:31
Copy link
Copy Markdown
Contributor
|
I think this solution is fine. Another option would be to fall back on the default API key here if externalRepoAuth, but I don't think that's any better than what you have. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for pushing the updated JS. I could have swore I ran the build but apparently not.
Yeah that's another option. The only downside of that is we then have to implement the fallback in each place that uses it. |
Sorry, something went wrong.
aeisenberg
approved these changes
Feb 17, 2021
This was referenced Feb 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aeisenberg, I noticed in #395 I unfortunately don't think it'll have the effect we wanted. I believe we wanted the standard token input to be used for normal auth and the external repository token. Currently that means you need to set it for both fields. I realise this is a bit error prone. If you have ideas for how to improve this situation do please go ahead.
Merge / deployment checklist