Support undefined, number in JSON module - #3980
Merged
mario-campos merged 3 commits intoJul 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
This PR extends the internal JSON schema-validation helpers to better distinguish “optional” vs “optional-or-null” fields, and to add first-class validators for number and object. It also updates start-proxy configuration schemas to use the new optionalOrNull semantics and adjusts unit tests accordingly.
Changes:
- Introduces isNumber, plus json.number and json.object validators.
- Renames the old “optional (undefined or null)” behavior to optionalOrNull and redefines optional to mean “undefined-only”.
- Updates start-proxy schemas and unit tests to reflect the new optional semantics.
| File | Description |
|---|---|
| src/start-proxy/types.ts | Switches relevant schema fields from optional to optionalOrNull for backwards-compatible null acceptance. |
| src/json/index.ts | Adds number/object validators and splits optional handling into optionalOrNull vs optional. |
| src/json/index.test.ts | Updates/expands tests to cover the new optional semantics (optionalOrNull vs optional). |
| lib/entry-points.js | Generated output (content excluded from review per policy). |
Review details
Files excluded by content exclusion policy (1)- lib/entry-points.js
- Files reviewed: 3/4 changed files
- Comments generated: 3
- Review effort level: Low
Sorry, something went wrong.
Comment thread
src/json/index.ts
Comment thread
src/json/index.ts
Outdated
Comment thread
src/json/index.ts
Comment on lines
+63
to
+67
| /** A validator for number fields in schemas. */ | ||
| export const number = { | ||
| validate: isNumber, | ||
| required: true, | ||
| } as const satisfies Validator<number>; |
mario-campos
added a commit
that referenced
this pull request
Jul 1, 2026
These have been spun off into #3980.
mbg
reviewed
Jul 1, 2026
Comment thread
src/json/index.ts
Outdated
Comment thread
src/json/index.ts
Outdated
Comment thread
src/json/index.test.ts
Outdated
Comment thread
src/json/index.test.ts
Outdated
mario-campos
force-pushed
the
mario-campos/add-optional-to-json
branch
from
46563f5 to
2a939e7
Compare
July 1, 2026 15:27
The previous implementation of `optional` is now `optionalOrNull`.
By @mbg Co-authored-by: Michael B. Gale <mbg@github.com>
mario-campos
force-pushed
the
mario-campos/add-optional-to-json
branch
from
5d92713 to
cbf67da
Compare
July 1, 2026 20:46
mbg
approved these changes
Jul 8, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several additions to the JSON schema-validation utilities:
This PR is a prerequisite for #3950.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist