Don't run update release branch workflow on forks. - #400
Merged
chrisgavin merged 1 commit intoFeb 24, 2021
Merged
chrisgavin merged 1 commit into
chrisgavin merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
robertbrignull
approved these changes
Feb 23, 2021
robertbrignull
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Seems reasonable as forks shouldn't need to use this workflow, but at the same time it's not harmful. Should the same change be applied to some of the other more "operational" workflows, e.g. check-expected-release-files, release-runner, split, update-supported-enterprise-server-versions?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The main reason that I modified this workflow specifically is that it creates a PR that mentions everyone who's contributed to the repository. In general I don't think we mind if people are running the other workflows, even if it is a bit pointless. |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist