FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Promote `NewRemoteFileAddresses` FF by mbg · Pull Request #4023 · github/codeql-action · GitHub

/ codeql-action Public

Promote NewRemoteFileAddresses FF - #4023

Merged
mbg merged 2 commits into
mainfrom
mbg/ff/remove-new-remote-file-addresses-ff
Jul 21, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Promote NewRemoteFileAddresses FF#4023
mbg merged 2 commits into
mainfrom
mbg/ff/remove-new-remote-file-addresses-ff

Conversation

mbg commented Jul 20, 2026

Copy link
Copy Markdown
Member

This PR promotes the NewRemoteFileAddresses FF to make its behaviour the default, following release and rollout of the feature.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

mbg self-assigned this Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 10:28
mbg requested a review from a team as a code owner July 20, 2026 10:28
github-actions Bot added the size/S Should be easy to review label Jul 20, 2026
Copilot AI reviewed Jul 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Promotes the new remote-file address format to the default behavior by removing its feature flag.

Changes:

  • Removes the NewRemoteFileAddresses feature flag and conditional checks.
  • Updates unit tests and proxy PR checks for unconditional support.
  • Refreshes generated artifacts.
Show a summary per file
File Description
src/feature-flags.ts Removes the promoted feature flag.
src/config/remote-file.ts Unconditionally accepts the new address format.
src/config/remote-file.test.ts Updates parsing tests for default behavior.
src/config/file.test.ts Removes obsolete feature setup.
src/config-utils.ts Enables new path detection unconditionally.
src/config-utils.test.ts Updates remote-path tests.
pr-checks/checks/start-proxy.yml Removes the obsolete feature environment variable.
.github/workflows/__start-proxy.yml Generated workflow; excluded from review.
lib/entry-points.js Generated JavaScript; excluded from review.

Review details

Files excluded by content exclusion policy (2)
  • .github/workflows/__start-proxy.yml
  • lib/entry-points.js
  • Files reviewed: 7/9 changed files
  • Comments generated: 0
  • Review effort level: Medium

mbg commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

I'll wait a bit before merging this

mbg added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 830c231 Jul 21, 2026
226 checks passed
mbg deleted the mbg/ff/remove-new-remote-file-addresses-ff branch July 21, 2026 11:38
This was referenced Jul 21, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
oscarsj oscarsj approved these changes

Assignees

mbg

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL